>> AFAIK, leaving e->adapter.summary_addr set is not an issue. >> >> Interesting, in kvm_s390_adapter_map(), we didn't synchronize again slot >> updates when doing the gmap_translate(), which looks wrong to me ... >> >> It seems to be the same thing here. I do wonder if it is safe to do a >> gmap_translate() here, looks like this can race with >> kvm_arch_commit_memory_region(). >> >> I would have assumed we need e.g., the slots_lock while doing the >> gmap_translate() - or a srcu_read_lock(&vcpu->kvm->srcu) or similar ... > > gmap_translate does this via the gmap and it holds the mm sem. gmap_unmap_segment > takes the same lock. So I think we are ok here. Ahh, I was looking at __gmap_translate(). Makes sense. -- Thanks, David / dhildenb
