On 2/14/20 8:27 AM, Cornelia Huck wrote: > On Thu, 6 Feb 2020 22:38:25 +0100 > Eric Farman <farman@xxxxxxxxxxxxx> wrote: > >> This seems misplaced in the middle of FSM, returning the schid >> field from inside the private struct. We could move this macro >> into vfio_ccw_private.h, but this doesn't seem to simplify things >> that much. Let's just remove it, and use the field directly. > > It had been introduced with the first set of traces, I'm now wondering > why, as it doesn't do any checking. Hrm, that's a decent question. I could refactor this, moving the routine into vfio_ccw_private.h and add those checks, rather than removing it outright. I honestly only stumbled on this when I tried to use get_schid() somewhere else, not realizing the definition was actually tucked away in here. And so I've left it on the end of this series as a matter of convenience/non-forgetfulness, but splitting it out by itself would be fine. > >> >> Signed-off-by: Eric Farman <farman@xxxxxxxxxxxxx> >> --- >> drivers/s390/cio/vfio_ccw_fsm.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >
