Re: [kvm-unit-tests PATCH v3 4/9] s390x: smp: Rework cpu start and active tracking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Well, I have restarts in the smp test and I don't want to always pass a
> psw if I know what the last restart psw was.
> Simply restarting into test_func or wait_for_flag is certainly no problem.
> 
>>

Makes sense.

>>> +	rc = sigp(addr, SIGP_RESTART, 0, NULL);
>>> +	if (rc)
>>> +		return rc;
>>> +	/*
>>> +	 * The order has been accepted, but the actual restart may not
>>> +	 * have been performed yet, so wait until the cpu is running.
>>> +	 */
>>> +	while (!smp_cpu_running(addr))
>>> +		mb();
>>
>> Should you make sure to stop the CPU before issuing the restart?
>> Otherwise you will get false positives if it is still running (but
>> hasn't processed the RESTART yet)
> 
> Good point
> 


-- 
Thanks,

David / dhildenb




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux