Re: [kvm-unit-tests PATCH v7 4/4] s390x: SCLP unit test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 13 Jan 2020 13:48:17 +0100
David Hildenbrand <david@xxxxxxxxxx> wrote:

[...]
	    
> >>
> >> I wonder if something like the following would be possible:
> >>
> >> expect_pgm_int();
> >> ...
> >> asm volatiole();
> >> ...
> >> sclp_wait_busy();
> >> check_pgm_int_code(PGM_INT_CODE_SPECIFICATION);  
> > 
> > we do not expect a specification exception, if that happens it's
> > a bug and the test should rightfully fail.  
> 
> Which one do we expect? (you're not checking for a specific one,
> should you?)

nothing, the call should succeed :)

> >   
> >> We would have to clear "sclp_busy" when we get a progam interrupt
> >> on a servc instruction - shouldn't be too hard to add to the
> >> program exception handler.  
> > 
> > Sure that could be done, but is it worth it to rework the program
> > interrupt handler only for one unit test?  
> 
> Good point. I don't like this particular code, but I can live with it
> :)
> 




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux