On 15/11/2019 12.39, Janosch Frank wrote: > On 11/15/19 11:07 AM, Thomas Huth wrote: >> On 24/10/2019 13.40, Janosch Frank wrote: >>> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx> >>> --- >>> arch/s390/include/asm/uv.h | 25 +++++++++++++++++++++++++ >>> arch/s390/kvm/diag.c | 1 + >>> arch/s390/kvm/kvm-s390.c | 20 ++++++++++++++++++++ >>> arch/s390/kvm/kvm-s390.h | 2 ++ >>> arch/s390/kvm/pv.c | 19 +++++++++++++++++++ >>> include/uapi/linux/kvm.h | 2 ++ >>> 6 files changed, 69 insertions(+) >> >> Add at least a short patch description what this patch is all about? >> >> Thomas >> > > I'm thinking about taking out the set cpu state changes and move it into > a later patch. > > > How about: > diag 308 subcode 0 and 1 require KVM and Ultravisor interaction, since > the cpus have to be set into multiple reset states. > > * All cpus need to be stopped > * The unshare all UVC needs to be executed > * The perform reset UVC needs to be executed > * The cpus need to be reset via the set cpu state UVC > * The issuing cpu needs to set state 5 via set cpu state Could you put the UVC names into quotes? Like: * The "unshare all" UVC needs to be executed ... I first had to read the sentence three times to really understand it. Thomas
