On 11/11/2019 17.25, Cornelia Huck wrote:
> On Fri, 8 Nov 2019 08:36:35 +0100
> Janosch Frank <frankja@xxxxxxxxxxxxx> wrote:
>
>> On 11/7/19 5:29 PM, Cornelia Huck wrote:
[...]
>>>
>>>> +int kvm_s390_pv_create_cpu(struct kvm_vcpu *vcpu)
>>>> +{
>>>> + int rc;
>>>> + struct uv_cb_csc uvcb = {
>>>> + .header.cmd = UVC_CMD_CREATE_SEC_CPU,
>>>> + .header.len = sizeof(uvcb),
>>>> + };
>>>> +
>>>> + /* EEXIST and ENOENT? */
>>>
>>> ?
>>
>> I was asking myself if EEXIST or ENOENT would be better error values
>> than EINVAL.
>
> EEXIST might be better, but I don't really like ENOENT.
>
>>>
>>>> + if (kvm_s390_pv_handle_cpu(vcpu))
>>>> + return -EINVAL;
FWIW, I'd also vote for EEXIST here.
Thomas
Attachment:
signature.asc
Description: OpenPGP digital signature
