On 08.11.19 18:14, Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Fri, 8 Nov 2019 17:50:22 +0100 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > * The function "_copy_apqns_from_user" contained a memory leak > because of a missing function call "kfree(kapqns)" for an if branch. > Link: https://lore.kernel.org/r/833d7d5e-6ede-6bdd-a2cc-2da7f0b03908@xxxxxxxxxx/ > > Thus complete the exception handling by this code replacement. > > * Delete local variables which became unnecessary with this refactoring > in two function implementations. > > Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support") > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> You were sending this from a different email address. Can you use the same for the sender and the signoff? Can you also change the subject to indicate the "fix". e.g. something like s390/pkey: fix memory leak in error case by using memdup_user() rather than open coding
