Re: [PATCH V7 3/6] mdev: introduce device specific ops

[Jason Wang <jasowang@xxxxxxxxxx>]

On 2019/11/5 上午5:50, Alex Williamson wrote:
> >   EXPORT_SYMBOL(mdev_set_drvdata);
> >   
> > +
> Extra whitespace
>
> >   /* Specify the class for the mdev device, this must be called during
> > - * create() callback.
> > - */
> > + * create() callback explicitly or implicity through the helpers
> s/implicity/implicitly/
>
> > + * provided by each class. */
> >   void mdev_set_class(struct mdev_device *mdev, u16 id)
> >   {
> >   	WARN_ON(mdev->class_id);
> > @@ -55,6 +56,26 @@ void mdev_set_class(struct mdev_device *mdev, u16 id)
> >   }
> >   EXPORT_SYMBOL(mdev_set_class);
> >   
> > +/* Specify the mdev device to be a VFIO mdev device, and set VFIO
> > + * device ops for it. This must be called from the create() callback
> > + * for VFIO mdev device.
> > + */
> Comment style.  Thanks,


Will fix them all.

Thanks


> Alex