On 04.11.19 11:29, David Hildenbrand wrote: > On 24.10.19 13:40, Janosch Frank wrote: >> From: Michael Mueller <mimu@xxxxxxxxxxxxx> >> >> The patch implements interruption injection for the following >> list of interruption types: >> >> - I/O >> __deliver_io (III) >> >> - External >> __deliver_cpu_timer (IEI) >> __deliver_ckc (IEI) >> __deliver_emergency_signal (IEI) >> __deliver_external_call (IEI) >> __deliver_service (IEI) >> >> - cpu restart >> __deliver_restart (IRI) > > What exactly is IRQ_PEND_EXT_SERVICE_EV? Can you add some comments whet the new interrupt does and why it is needed in this context? Thanks I did that code. What about the following add-on description. The ultravisor does several checks on injected interrupts. For example it will check that for an sclp interrupt with an sccb address we had an servc exit and exit with a validity intercept. As the hypervisor must avoid valitity intercepts we now mask invalid interrupts. There are also sclp interrupts that only inject an event (e.g. an input event on the sclp consoles) those interrupts must not be masked. Let us split out these "event interupts" from the normal sccb interrupts into IRQ_PEND_EXT_SERVICE_EV.