On 09/10/2019 18:51, Christoph Hellwig wrote:
On Wed, Oct 09, 2019 at 12:39:30PM +0100, Ben Dooks wrote:
When building for arm, cpuinfo_op generates a warning due
to no declaration. Since this is used in fs/proc/cpuinfo.c
and inconsitently declared across archiectures move the
declaration info <linux/seq_file.h>. This means that the
cpuinfo_op will have a declaration any place it is used.
Removes the following sparse warning:
arch/arm/kernel/setup.c:1320:29: warning: symbol 'cpuinfo_op' was not declared. Should it be static?
I like the consolidation, but I don't think seq_file.h is the right
place. A procfs or cpu topology related header seems like the better
choice.
Ok, thanks.
I'll have a look at where else it could go, but I'm not sure if I have
the resources to build /all/ kernels that this would effect.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
