Re: [PATCH v6 04/10] s390: vfio-ap: filter CRYCB bits for unavailable queue devices

[Tony Krowiak <akrowiak@xxxxxxxxxxxxx>]

On 9/18/19 1:04 PM, Halil Pasic wrote:
> On Fri, 13 Sep 2019 17:26:52 -0400
> Tony Krowiak <akrowiak@xxxxxxxxxxxxx> wrote:
>
> > +static void vfio_ap_mdev_get_crycb_matrix(struct ap_matrix_mdev *matrix_mdev)
> > +{
> > +	unsigned long apid, apqi;
> > +	unsigned long masksz = BITS_TO_LONGS(AP_DEVICES) *
> > +			       sizeof(unsigned long);
> > +
> > +	memset(matrix_mdev->crycb.apm, 0, masksz);
> > +	memset(matrix_mdev->crycb.apm, 0, masksz);
>
> I guess you wanted to zero out aqm here (and not apm again)!

Cut and paste without edit. I'll fix it.

> > +	memcpy(matrix_mdev->crycb.adm, matrix_mdev->matrix.adm, masksz);