On 8/21/19 12:47 PM, Janosch Frank wrote: > It's needed in multiple tests now. > > Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx> > --- > lib/s390x/asm/arch_def.h | 16 ++++++++++++++++ > s390x/skey.c | 18 ------------------ > 2 files changed, 16 insertions(+), 18 deletions(-) > > diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h > index 4bbb428..5f8f45e 100644 > --- a/lib/s390x/asm/arch_def.h > +++ b/lib/s390x/asm/arch_def.h > @@ -240,4 +240,20 @@ static inline void enter_pstate(void) > load_psw_mask(mask); > } > > +static inline int stsi(void *addr, int fc, int sel1, int sel2) > +{ > + register int r0 asm("0") = (fc << 28) | sel1; > + register int r1 asm("1") = sel2; > + int cc; > + > + asm volatile( > + "stsi 0(%3)\n" > + "ipm %[cc]\n" > + "srl %[cc],28\n" > + : "+d" (r0), [cc] "=d" (cc) > + : "d" (r1), "a" (addr) > + : "cc", "memory"); > + return cc; Maybe mention the changed return value in the patch description. Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>