On Fri, Aug 16, 2019 at 11:16:08PM +0200, Hans de Goede wrote: > diff --git a/include/linux/sha256.h b/include/crypto/sha256.h > similarity index 100% > rename from include/linux/sha256.h > rename to include/crypto/sha256.h <crypto/sha.h> already has the declarations for both SHA-1 and SHA-2, including SHA-256. So I'm not sure a separate sha256.h is appropriate. How about putting these declarations in <crypto/sha.h>? - Eric