Hi! > > There's a loop just below here that should be rewritten in the typical > style: > > i = PCI_IOV_RESOURCES; > for (; i < PCI_SRIOV_NUM_BARS + PCI_IOV_RESOURCES; i++) { > len = pci_resource_len(pdev, i); > > Again, not strictly related to this patch, but probably trivial enough > to do in the same patch. > I think it's already fixed in a separate patch https://lkml.org/lkml/2019/8/6/694 Thanks for the review, I will send v2. Denis