Hi Steffen, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc3 next-20190808] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Steffen-Maier/scsi-core-fix-missing-cleanup_rq-for-SCSI-hosts-without-request-batching/20190808-052017 config: s390-allmodconfig (attached as .config) compiler: s390-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers//scsi/scsi_lib.c:1824:3: error: 'const struct blk_mq_ops' has no member named 'cleanup_rq'; did you mean 'queue_rq'? .cleanup_rq = scsi_cleanup_rq, ^~~~~~~~~~ queue_rq drivers//scsi/scsi_lib.c:1824:16: error: 'scsi_cleanup_rq' undeclared here (not in a function); did you mean 'scsi_queue_rq'? .cleanup_rq = scsi_cleanup_rq, ^~~~~~~~~~~~~~~ scsi_queue_rq >> drivers//scsi/scsi_lib.c:1824:16: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init] drivers//scsi/scsi_lib.c:1824:16: note: (near initialization for 'scsi_mq_ops') cc1: some warnings being treated as errors vim +1824 drivers//scsi/scsi_lib.c 1811 1812 static const struct blk_mq_ops scsi_mq_ops = { 1813 .get_budget = scsi_mq_get_budget, 1814 .put_budget = scsi_mq_put_budget, 1815 .queue_rq = scsi_queue_rq, 1816 .complete = scsi_softirq_done, 1817 .timeout = scsi_timeout, 1818 #ifdef CONFIG_BLK_DEBUG_FS 1819 .show_rq = scsi_show_rq, 1820 #endif 1821 .init_request = scsi_mq_init_request, 1822 .exit_request = scsi_mq_exit_request, 1823 .initialize_rq_fn = scsi_initialize_rq, > 1824 .cleanup_rq = scsi_cleanup_rq, 1825 .busy = scsi_mq_lld_busy, 1826 .map_queues = scsi_map_queues, 1827 }; 1828 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
