On Fri, 2 Aug 2019 at 09:46, Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote: > > On Thu, Aug 01, 2019 at 08:28:56PM +0300, Ard Biesheuvel wrote: > > On Thu, 1 Aug 2019 at 15:28, Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote: > > > Still not... with linux-next as of today I get this (s390 defconfig): > > > > > > ERROR: "crypto_aegis128_decrypt_chunk_simd" [crypto/aegis128.ko] undefined! > > > ERROR: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined! > > > ERROR: "crypto_aegis128_encrypt_chunk_simd" [crypto/aegis128.ko] undefined! > > > scripts/Makefile.modpost:105: recipe for target 'modules-modpost' failed > > > > > > > Hello Heiko, > > > > Apologies for the breakage. The first two fixes addressed obvious > > shortcomings in my code, but with this issue, I'm a bit puzzled tbh. > > The calls to these missing functions should be optimized away, since > > have_simd never gets assigned if CONFIG_CRYPTO_AEGIS128_SIMD is not > > defined, but for some reason, this isn't working. Which version of GCC > > are you using? > > Plain vanilla gcc 9.1.0. > > > Also, could you please try whether the patch below fixes the problem? Thanks > > https://lore.kernel.org/linux-crypto/20190729074434.21064-1-ard.biesheuvel@xxxxxxxxxx/ > > Yes, with that patch applied the code compiles. > Thanks for confirming. Since Voldis is reporting GCC 9.1.x as well, this might be a compiler regression (and it explains why I did not see the issue locally) In any case, the patches have been reverted now, so I will resubmit them with the above change folded in. Thanks, Ard.
