On Wed, Jul 31, 2019 at 04:41:14PM +0200, Michal Hocko wrote: > On Wed 31-07-19 17:21:29, Mike Rapoport wrote: > > On Wed, Jul 31, 2019 at 03:00:37PM +0200, Michal Hocko wrote: > > > > > > I am sorry, but I still do not follow. Who is consuming that node id > > > information when NUMA=n. In other words why cannot we simply do > > > > We can, I think nobody cared to change it. > > It would be great if somebody with the actual HW could try it out. > I can throw a patch but I do not even have a cross compiler in my > toolbox. Well, it compiles :) > > > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > > > index a015a951c8b7..3a47e8db8d1c 100644 > > > --- a/arch/microblaze/mm/init.c > > > +++ b/arch/microblaze/mm/init.c > > > @@ -175,14 +175,9 @@ void __init setup_memory(void) > > > > > > start_pfn = memblock_region_memory_base_pfn(reg); > > > end_pfn = memblock_region_memory_end_pfn(reg); > > > - memblock_set_node(start_pfn << PAGE_SHIFT, > > > - (end_pfn - start_pfn) << PAGE_SHIFT, > > > - &memblock.memory, 0); > > > + memory_present(0, start_pfn << PAGE_SHIFT, end_pfn << PAGE_SHIFT); > > > > memory_present() expects pfns, the shift is not needed. > > Right. > > -- > Michal Hocko > SUSE Labs > -- Sincerely yours, Mike.
