Re: [PATCH] vfio-ccw: make vfio_ccw_async_region_ops static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 29 Jul 2019 10:38:52 +0200
Vasily Gorbik <gor@xxxxxxxxxxxxx> wrote:

> Since vfio_ccw_async_region_ops is not exported and has no reason to be
> globally visible make it static to avoid the following sparse warning:
> drivers/s390/cio/vfio_ccw_async.c:73:30: warning: symbol 'vfio_ccw_async_region_ops' was not declared. Should it be static?

Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
> 
> Signed-off-by: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> ---
>  drivers/s390/cio/vfio_ccw_async.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/cio/vfio_ccw_async.c b/drivers/s390/cio/vfio_ccw_async.c
> index 8c1d2357ef5b..7a838e3d7c0f 100644
> --- a/drivers/s390/cio/vfio_ccw_async.c
> +++ b/drivers/s390/cio/vfio_ccw_async.c
> @@ -70,7 +70,7 @@ static void vfio_ccw_async_region_release(struct vfio_ccw_private *private,
>  
>  }
>  
> -const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
> +static const struct vfio_ccw_regops vfio_ccw_async_region_ops = {
>  	.read = vfio_ccw_async_region_read,
>  	.write = vfio_ccw_async_region_write,
>  	.release = vfio_ccw_async_region_release,

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>

Should I queue this and send a pull request (currently, there's nothing
else pending), or do you want to apply this directly?



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux