On Tue, 16 Jul 2019 15:11:38 +0200 Vasily Gorbik <gor@xxxxxxxxxxxxx> wrote: > On Tue, Jul 16, 2019 at 10:30:14AM +0000, Petr Tesarik wrote: > > On Tue, 16 Jul 2019 00:12:19 +0200 > > Vasily Gorbik <gor@xxxxxxxxxxxxx> wrote: > > > > > Extend "parmarea" to include an offset of the version string, which is > > > stored as 8-byte big endian value. > > > > > > To retrieve version string from bzImage reliably, one should check the > > > presence of "S390EP" ascii string at 0x10008 (available since v3.2), > > > then read the version string offset from 0x10428 (which has been 0 > > > since v3.2 up to now). The string is null terminated. > > > > > > Could be retrieved with the following "file" command magic (requires > > > file v5.34): > > > 8 string \x02\x00\x00\x18\x60\x00\x00\x50\x02\x00\x00\x68\x60\x00\x00\x50\x40\x40\x40\x40\x40\x40\x40\x40 Linux S390 > > > >0x10008 string S390EP > > > >>0x10428 bequad >0 > > > >>>(0x10428.Q) string >\0 \b, version %s > > > > > > Signed-off-by: Vasily Gorbik <gor@xxxxxxxxxxxxx> > > > > This looks great! Much cleaner than the original approach. > > > > Thank you, > > Petr T > > Then I'll add > Reported-by: Petr Tesarik <ptesarik@xxxxxxxx> > Suggested-by: Petr Tesarik <ptesarik@xxxxxxxx> > if you don't mind and try to queue that for 5.3. Oh, sure, please add these lines and go ahead. Thank you again, Petr T
Attachment:
pgpEIQ9sULIbu.pgp
Description: Digitálnà podpis OpenPGP
