On 7/12/19 7:30 AM, Cornelia Huck wrote:
> On Thu, 11 Jul 2019 10:28:55 -0400
> Farhan Ali <alifm@xxxxxxxxxxxxx> wrote:
>
>> We now support CLEAR SUBCHANNEL and HALT SUBCHANNEL
>> via ccw_cmd_region.
>>
>> Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
>> Signed-off-by: Farhan Ali <alifm@xxxxxxxxxxxxx>
>> ---
>> Documentation/s390/vfio-ccw.rst | 31 ++++++++++++++++++++++++++++---
>> 1 file changed, 28 insertions(+), 3 deletions(-)
>
> (...)
>
>> +vfio-ccw cmd region
>> +-------------------
>> +
>> +The vfio-ccw cmd region is used to accept asynchronous instructions
>> +from userspace.
>> +
>
> Add :: and indent the structure so that we get proper formatting?
>
> (Sorry about not noticing this last time; but I can add it while
> applying if there are no other comments.)
>
>> +#define VFIO_CCW_ASYNC_CMD_HSCH (1 << 0)
>> +#define VFIO_CCW_ASYNC_CMD_CSCH (1 << 1)
>> +struct ccw_cmd_region {
>> + __u32 command;
>> + __u32 ret_code;
>> +} __packed;
>> +
>> +This region is exposed via region type VFIO_REGION_SUBTYPE_CCW_ASYNC_CMD.
>> +
>> +Currently, CLEAR SUBCHANNEL and HALT SUBCHANNEL use this region.
>> +
>
> Otherwise,
> Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
>
Also good...
Reviewed-by: Eric Farman <farman@xxxxxxxxxxxxx>
