On Thu, 6 Jun 2019 13:51:19 +0200 Halil Pasic <pasic@xxxxxxxxxxxxx> wrote: > * Documentation is still very sketchy. I'm committed to improving this, > but I'm currently hampered by some dependencies currently. Have the "dependencies" been resolved in the meantime? It probably would be a good idea to include some documentation for what needs to be dma and what doesn't somewhere in the kernel documentation (IIRC we have a s390 drivers 'book' partially generated from kerneldoc; there's some general document about the cio interfaces as well, but I'm not sure how up-to-date that is.) I think the code in here looks sane from my point of view (except for the one easy-to-fix issue I found); I would be fine with the virtio-ccw patches making it into the kernel via the s390 tree (and not via the virtio tree).
