Re: [PATCH v3 2/8] s390/cio: introduce DMA pools to cio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 3 Jun 2019 16:04:28 +0200
Halil Pasic <pasic@xxxxxxxxxxxxx> wrote:

> On Mon, 3 Jun 2019 14:09:02 +0200
> Michael Mueller <mimu@xxxxxxxxxxxxx> wrote:
> 
> > >> @@ -1059,16 +1168,19 @@ static int __init css_bus_init(void)
> > >>   	if (ret)
> > >>   		goto out_unregister;
> > >>   	ret = register_pm_notifier(&css_power_notifier);
> > >> -	if (ret) {
> > >> -		unregister_reboot_notifier(&css_reboot_notifier);
> > >> -		goto out_unregister;
> > >> -	}
> > >> +	if (ret)
> > >> +		goto out_unregister_rn;
> > >> +	ret = cio_dma_pool_init();
> > >> +	if (ret)
> > >> +		goto out_unregister_rn;  
> > > 
> > > Don't you also need to unregister the pm notifier on failure here?  
> > 
> > Mmh, that was the original intention. Thanks!
> 
> I suppose we could also move cio_dma_pool_init() right before the
> register_reboot_notifier() call and goto out_unregister on error.
> 

Forget it, then we have to rollback the pool creation if the register
stuff fails... Sorry for the noise.

Regards,
Halil




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux