Re: [kvm-unit-tests PATCH 3/3] s390x: Add prefix for dxc afp emulator test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/02/2019 09.49, Janosch Frank wrote:
> Without it we have two reports that look the same, but don't have the
> same control register state for the test.
> 
> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> ---
>  s390x/emulator.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/s390x/emulator.c b/s390x/emulator.c
> index f49c414..4c26b80 100644
> --- a/s390x/emulator.c
> +++ b/s390x/emulator.c
> @@ -266,6 +266,7 @@ static void test_dxc(void)
>  	lc->dxc_vxc = 0x12345678;
>  	set_fpc_dxc(0);
>  
> +	report_prefix_push("afp");
>  	expect_pgm_int();
>  	asm volatile("	.insn	rrf,0xb9600000,%0,%0,8,0\n"
>  		     : : "r"(0) : "memory");
> @@ -273,7 +274,7 @@ static void test_dxc(void)
>  
>  	report("dxc in LC", lc->dxc_vxc == 0xff);
>  	report("dxc in FPC", get_fpc_dxc() == 0xff);
> -
> +	report_prefix_pop();
>  
>  	/* DXC (0xff) is to be stored in LC only on a trap (CRT) without AFP */
>  	lc->dxc_vxc = 0x12345678;

Maybe add a prefix a la "no-afp" for the second test, too?

Anyway:

Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux