On Mon, Feb 04, 2019 at 04:44:55PM +0100, Heiko Carstens wrote: > Commit 626a5f66da0d19 ("s390: bpf: implement jitting of JMP32") added > JMP32 code-gen support for s390. However it triggers the warning below > due to some unusual gotos in the original s390 bpf jit code. > > Add a couple of additional "is_jmp32" initializations to fix this. > Also fix the wrong opcode for the "llilf" instruction that was > introduced with the same commit. > > arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn': > arch/s390/net/bpf_jit_comp.c:248:55: warning: 'is_jmp32' may be used uninitialized in this function [-Wmaybe-uninitialized] > _EMIT6(op1 | reg(b1, b2) << 16 | (rel & 0xffff), op2 | mask); \ > ^ > arch/s390/net/bpf_jit_comp.c:1211:8: note: 'is_jmp32' was declared here > bool is_jmp32 = BPF_CLASS(insn->code) == BPF_JMP32; > > Fixes: 626a5f66da0d19 ("s390: bpf: implement jitting of JMP32") > Cc: Jiong Wang <jiong.wang@xxxxxxxxxxxxx> > Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> > Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx> Applied to bpf-next. Thanks!