On 1/24/19 3:43 AM, Cornelia Huck wrote:
> On Thu, 24 Jan 2019 09:32:36 +0100
> Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote:
>
>> On 06.12.2018 23:30, Collin Walling wrote:
>>> The s390x diagnose 318 instruction sets the control program name code (CPNC)
>>> and control program version code (CPVC) to provide useful information
>>> regarding the OS during debugging. The CPNC is explicitly set to 4 to
>>> indicate a Linux/KVM environment.
>>>
>>> The CPVC is a 7-byte value containing:
>> [...]
>>> /*
>>> + * Issue diagnose 318 to set the control program name and
>>> + * version codes.
>>> + */
>>> +static void __init setup_control_program_code(void)
>>> +{
>>> + union diag318_info diag318_info = {
>>> + .cpnc = CPNC_LINUX,
>>> + .cpvc_linux = LINUX_VERSION_CODE,
>>> + .cpvc_distro = {0},
>>> + };
>>
>> As we still discuss the encoding of the structure, I would like to set
>> cpvc_linux to 0 when applying the patch. We can then settle the detailed
>> structure later on.
>
> So, setting cpvc_linux to something != 0 would indicate that
> cpvc_distro is meaningful? Makes sense, I guess.
>
>>
>> Ok?
>>
>
This is fine with me.
--
Respectfully,
- Collin Walling
