On 04.01.19 09:56, Jens Remus wrote: > Hi Janosch, > > happy new year! Thanks, same to you. > > On 03.01.2019 11:07, Janosch Frank wrote: >> LPAR and z/VM start in esam mode depending on the hardware, so we need > > Did you consider the CZAM facility? You already use a so called "short > PSW" (which is compatible to the ESA/390 PSW, as you did not set bit 31). > > LPAR and z/VM start in esam or esame mode, depending on the hardware > CZAM facility and z/VM MACHINE setting. > > See POP section "Load State": > > "When neither the configuration-z/Architecture-architectural-mode (CZAM) > facility nor the ESA/390-compatibility-mode facility are installed, this > sets the architectural mode to the ESA/390 mode. When the > ESA/390-compatibility-mode facility is installed, this sets the > architecture mode to the ESA/390-compatibility mode. When the CZAM > facility is installed, the architectural mode is unchanged (that is, it > remains in the z/Architecture architectural mode)." > >> to switch to z/Arch and set 64 bit addressing. I don't really want to test in which state I am and blindly setting z/Arch and 64 bit is a valid course of action according to the AR. > > Wouldn't it be nice to mention this in the commit subject: > > s390x: Switch to z/Arch and 64-bit addressing [mode] As commented yesterday (Message-ID: <9644d7ab-d815-720d-f1a1-eee1a6a0c253@xxxxxxxxxxxxx>): The title will be changed to: s390x: Switch to z/Arch and enable 64 bit addressing mode Also I will move the sam64 from the previous patch into this one. I might add to the comment that we do this no matter what configuration we start out in, because it doesn't produce an exception.
Attachment:
signature.asc
Description: OpenPGP digital signature
