On Mon, 19 Nov 2018 18:25:35 +0100
Michael Mueller <mimu@xxxxxxxxxxxxx> wrote:
> The patch implements a handler for GIB alert interruptions
> on the host. Its task is to alert storage backed guests that
> interrupts are pending for them.
>
> A GIB alert interrupt statistic counter is added as well:
>
> $ cat /proc/interrupts
> CPU0 CPU1
> ...
> GAL: 0 0 [I/O] GIB Alert
> ...
>
> Signed-off-by: Michael Mueller <mimu@xxxxxxxxxxxxx>
> ---
> arch/s390/include/asm/irq.h | 1 +
> arch/s390/include/asm/isc.h | 1 +
> arch/s390/kernel/irq.c | 1 +
> arch/s390/kvm/interrupt.c | 57 +++++++++++++++++++++++++++++++++++++--------
> arch/s390/kvm/kvm-s390.c | 6 +++++
> arch/s390/kvm/kvm-s390.h | 5 ++++
> 6 files changed, 61 insertions(+), 10 deletions(-)
> @@ -2919,7 +2920,7 @@ static void nullify_gisa(struct kvm_s390_gisa *gisa)
> * belongs to. Thus, the pending guest interruption will be processed
> * in SIE context.
> */
> -static void __maybe_unused process_gib_alert_list(void)
> +static void process_gib_alert_list(void)
Can't you merge the patch creating that function into this patch, so
you don't need to add __maybe_unused in the first place? (I don't think
the function is big enough to need separate review.)
> {
> struct kvm_s390_gisa *gisa = unlink_gib_alert_list();
> struct kvm_s390_gisa *next_alert;
