On Thu, 25 Oct 2018 19:15:20 +0200 Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote: > Let's register the mediated device when all the data structures > which could be used are initialized. > > Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx> > Reviewed-by: Eric Farman <farman@xxxxxxxxxxxxx> > --- > drivers/s390/cio/vfio_ccw_drv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c > index f47d16b5810b..33fd53f49bf2 100644 > --- a/drivers/s390/cio/vfio_ccw_drv.c > +++ b/drivers/s390/cio/vfio_ccw_drv.c > @@ -134,14 +134,14 @@ static int vfio_ccw_sch_probe(struct subchannel *sch) > if (ret) > goto out_free; > > - ret = vfio_ccw_mdev_reg(sch); > - if (ret) > - goto out_disable; > - > INIT_WORK(&private->io_work, vfio_ccw_sch_io_todo); > atomic_set(&private->avail, 1); > private->state = VFIO_CCW_STATE_STANDBY; > > + ret = vfio_ccw_mdev_reg(sch); > + if (ret) > + goto out_disable; > + > return 0; > > out_disable: This patch looks fine, but ISTR that Halil was unhappy with the patch description. Any opinion on that? I'd like to queue this for 4.20.
