On Fri, 9 Nov 2018 03:39:28 +0100 Eric Farman <farman@xxxxxxxxxxxxx> wrote: > If pfn_array_alloc fails somehow, we need to release the pfn_array_table > that was malloc'd earlier. > > Signed-off-by: Eric Farman <farman@xxxxxxxxxxxxx> > --- > drivers/s390/cio/vfio_ccw_cp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c > index fd77e46eb3b2..ef5ab45d94b3 100644 > --- a/drivers/s390/cio/vfio_ccw_cp.c > +++ b/drivers/s390/cio/vfio_ccw_cp.c > @@ -528,7 +528,7 @@ static int ccwchain_fetch_direct(struct ccwchain *chain, > > ret = pfn_array_alloc_pin(pat->pat_pa, cp->mdev, ccw->cda, ccw->count); > if (ret < 0) > - goto out_init; > + goto out_unpin; > > /* Translate this direct ccw to a idal ccw. */ > idaws = kcalloc(ret, sizeof(*idaws), GFP_DMA | GFP_KERNEL); It's a bit confusing that this will also call vfio_unpin_pages() even though there should not be any pinned pages at that point in time; but from what I see, it should not hurt, so this patch is fine.
