Hi Randy, On Tue, Nov 6, 2018 at 2:06 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > On 11/5/18 2:12 PM, Geert Uytterhoeven wrote: > > On Mon, Nov 5, 2018 at 11:07 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > >> Below is the list of build error/warning regressions/improvements in > >> v4.20-rc1[1] compared to v4.19[2]. > >> > >> Summarized: > >> - build errors: +3/-0 > >> - build warnings: +449/-2712 > >> > >> Happy fixing! ;-) > >> > >> Thanks to the linux-next team for providing the build service. > >> > >> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/651022382c7f8da46cb4872a545ee1da6d097d2a/ (all 240 configs) > >> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d/ (all 240 configs) > >> > >> > >> *** ERRORS *** > >> > >> + /kisskb/src/sound/pci/hda/patch_ca0132.c: error: implicit declaration of function 'pci_iomap' [-Werror=implicit-function-declaration]: => 8799:3 > > > > sh4-all{mod,yes}config > > > > Looks like d9b84a15892c0233 ("ALSA: hda: Fix implicit definition of > > pci_iomap() on SH") > > is not sufficient? > > Different problem. This is about "select": > > config SND_SOC_ALL_CODECS > tristate "Build all ASoC CODEC drivers" > > That enables (sets): > select SND_SOC_HDAC_HDA > which selects SND_HDA even though CONFIG_PCI is not enabled. > > After SND_HDA is selected (above), the Kconfig symbols in > sound/pci/hda/Kconfig are available for enabling, so > SND_HDA_CODEC_CA0132 is enabled but will not build. Thanks for looking into this! > One simple solution (but possibly too naive) is: > > --- > sound/soc/codecs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- lnx-420-rc1.orig/sound/soc/codecs/Kconfig > +++ lnx-420-rc1/sound/soc/codecs/Kconfig > @@ -82,7 +82,7 @@ config SND_SOC_ALL_CODECS > select SND_SOC_ES7241 > select SND_SOC_GTM601 > select SND_SOC_HDAC_HDMI > - select SND_SOC_HDAC_HDA > + select SND_SOC_HDAC_HDA if PCI > select SND_SOC_ICS43432 > select SND_SOC_INNO_RK3036 > select SND_SOC_ISABELLE if I2C I guess that will work. There are already plenty of "select foo if bar" lines. However, looking at what else can enable SND_HDA, I think it should be select SND_SOC_HDAC_HDA if SND_PCI || ARCH_TEGRA That still leaves the issue that pci_iomap() on SH should be an empty stub if PCI is not available, like on other architectures. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
