Re: [PATCH 09/10] KVM: s390: add and wire function gib_alert_irq_handler()

[Michael Mueller <mimu@xxxxxxxxxxxxx>]

On 31.10.18 13:10, Pierre Morel wrote:
> >   void kvm_s390_gib_destroy(void)
> >   {
> >       if (!gib)
> >           return;
>
> I think we should clear the alert list
> before unregistering the interruption.

That is the host shutdown case

What do you mean exactly with "clear the alert list" ?

> > +    unregister_adapter_interrupt(&gib_alert_irq);
>
> We also should unregister the adapter interrupt only after having
> unregister the GIB.


so you suggest:

  chsc_sgib(0)
  unregister_adapter_interrupt()

makes sense.


> >       chsc_sgib(0);
> >       free_page((unsigned long)gib);
> >       gib = NULL;
> > @@ -3034,6 +3057,14 @@ void kvm_s390_gib_init(u8 nisc)
> >           return;
> >       }
> > +    gib_alert_irq.isc = nisc;
> > +    rc = register_adapter_interrupt(&gib_alert_irq);
> > +    if (rc) {
> > +        KVM_EVENT(3, "gib 0x%pK GAI registration failed rc: %d",
> > +              gib, rc);
> > +        goto out_free;
> > +    }