On 10/23/18 8:55 AM, Stefan Haberland wrote:
> On 16.10.18 16:40, Jens Axboe wrote:
>> Since e443343e509a we haven't had a request_fn attached to
>> this driver, hence any code inside an if (q->request_fn) is
>> unreachable.
>>
>> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
>> Cc: linux-s390@xxxxxxxxxxxxxxx
>> Fixes: e443343e509a ("s390/dasd: blk-mq conversion")
>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>> ---
>
> Thanks for the patch. I had a look at the code. The ifdef part seems to
> be broken since a very long time so I will remove it as you suggested
> but I will keep and fix the dasd_info->chanq_len counter part without
> the request_fn check. I will put a patch on Martins queue accordingly.
Great that you want to fix it. Since this is holding up a patch queue,
I'd appreciate if I can carry it in my tree to avoid having dependencies
on external trees for the legacy IO path removal for 4.21.
Note that the entire block has been unreachable since the conversion
went in May 2017, and nobody noticed.
--
Jens Axboe
