When we receive a subchannel event the alternative is:
- to handle the event in the mediated device driver,
- to let the guest handle it.
We choose to let the guest handle the changes even we do
not dynamically signal the event to the guest for now.
There is no reason to change the state of the mediated device
here but in error cases.
Let's suppress the state change.
Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
---
drivers/s390/cio/vfio_ccw_drv.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index b29a96f..e7416dd 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -199,18 +199,11 @@ static int vfio_ccw_sch_event(struct subchannel *sch, int process)
rc = 0;
goto out_unlock;
}
-#if 0
/*
- * We must find a solution to report the change to the guest
- * until there I see no need to change the state of the SCH
- * here.
+ * We must find a solution to signal the change to the guest,
+ * and let it handle the event.
+ * There is no need to update the mediated device state.
*/
- private = dev_get_drvdata(&sch->dev);
- if (private->state == VFIO_CCW_STATE_NOT_OPER) {
- private->state = private->mdev ? VFIO_CCW_STATE_IDLE :
- VFIO_CCW_STATE_STANDBY;
- }
-#endif
rc = 0;
out_unlock:
--
2.7.4
