Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

[Cornelia Huck <cohuck@xxxxxxxxxx>]

On Fri, 28 Sep 2018 09:33:21 -0400
Tony Krowiak <akrowiak@xxxxxxxxxxxxxxxxxx> wrote:

> From: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
> 
> Fixes case statement in vfio_ap_mdev_copy_masks() function in
> vfio-ap-ops.c.
> ---
>  drivers/s390/crypto/vfio_ap_ops.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> index e1e1beaaeba5..86b42487a51c 100644
> --- a/drivers/s390/crypto/vfio_ap_ops.c
> +++ b/drivers/s390/crypto/vfio_ap_ops.c
> @@ -741,11 +741,12 @@ static void vfio_ap_mdev_copy_masks(struct ap_matrix_mdev *matrix_mdev)
>  		break;
>  	case CRYCB_FORMAT1:
>  	case CRYCB_FORMAT0:
> -	default:
>  		apm = (unsigned long *)crycb->apcb0.apm;
>  		aqm = (unsigned long *)crycb->apcb0.aqm;
>  		adm = (unsigned long *)crycb->apcb0.adm;
>  		break;
> +	default:
> +		return;

/* cannot happen */

?

>  	}
>  
>  	nbytes = DIV_ROUND_UP(matrix_mdev->matrix.apm_max + 1, BITS_PER_BYTE);