Hi Julian, On Wed, 2018-09-12 at 16:50 +0200, Julian Wiedmann wrote: > Thanks Jean, but I'd rather pass on this one. I don't see an improvement > in readability, and performance just isn't a concern for this specific > path... there's hardly any traffic on the interface's control plane. Sure, you will know better. The initial optimization of qeth_get_ipa_msg() and qeth_get_ipa_cmd_name() made me wonder if maybe performance was considered important on these paths, and this is why I wanted to pay attention that my changes would not cause a performance regression. If there is no such concern then all is well and this second patch is indeed not needed. Thanks, -- Jean Delvare SUSE L3 Support
