On Sat, Aug 18, 2018 at 05:28:05PM +0800, Jiecheng Wu wrote: > Function sysinfo_show() defined in arch/s390/kernel/sysinfo.c returns > wrong error code when function get_zeroed_page() fails. The correct > return code when get_zeroed_page() fails is -ENOMEM but the code returns 0. > --- > arch/s390/kernel/sysinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kernel/sysinfo.c b/arch/s390/kernel/sysinfo.c > index 12f80d1..1da471f 100644 > --- a/arch/s390/kernel/sysinfo.c > +++ b/arch/s390/kernel/sysinfo.c > @@ -280,7 +280,7 @@ static int sysinfo_show(struct seq_file *m, void *v) > int level; > > if (!info) > - return 0; > + return -ENOMEM; > level = stsi(NULL, 0, 0, 0); > if (level >= 1) > stsi_1_1_1(m, info); I did not ask to add line breaks to the patch description but a proper "Signed-off-by: ..." line from you. Again: have a look at Documentation/process/submitting-patches.rst within the kernel sources, and there especially section "11) Sign your work - the Developer's Certificate of Origin".