Hi Philipp, On 08/01/2018 05:55 PM, Philipp Rudo wrote: > Hi Javier, > > On Wed, 1 Aug 2018 11:11:08 +0200 > Javier Martinez Canillas <javierm@xxxxxxxxxx> wrote: > >> Hi Philipp, >> >> On 07/25/2018 01:36 PM, Philipp Rudo wrote: >>> Since version 198 (Feb 2013) systemd contains kernel-install, a script >>> managing kernel installs. This script allows execution of drop-in scripts >>> for customization. Add such a drop-in script to s390-tools to handle the >>> installation of zfcpdump kernels and simplify interactions between zfcpdump >>> and zipl. >>> >>> The script supports two installation modes. One recommended by the >>> BootLoaderSpecs [1] to /boot/<machine-id>/<kernel-version> directories and >>> one directly to /boot. In the second case files are renamed during >>> installation to <original-name>-<kernel-version> to guarantee unique names. >>> >> >> IIUC even when the script supports these two paths, zipl only supports to have >> the zfcpdump image in $ZFCPDUMP_IMAGE, and that's why the script uses symlinks >> to point to the different supported installation paths. >> >> Maybe you can mention this in the commit message and script header? Since at >> least for me it wasn't evident until I read the code. > > Sure I can do. I won't be in the office the rest of the week. So you have to > wait for next week till I sent v2. > Yes, no worries. Is a small nit anyways. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
