Re: [PATCH v13 06/18] x86/xen/time: initialize pv xen time in init_hypervisor_platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -void __ref xen_init_time_ops(void)
> +void __init xen_init_time_ops(void)
>  {
>         pv_time_ops = xen_time_ops;
>
> @@ -542,17 +542,11 @@ void __init xen_hvm_init_time_ops(void)
>                 return;
>
>         if (!xen_feature(XENFEAT_hvm_safe_pvclock)) {
> -               printk(KERN_INFO "Xen doesn't support pvclock on HVM,"
> -                               "disable pv timer\n");
> +               pr_info("Xen doesn't support pvclock on HVM, disable pv timer");
>                 return;
>         }
> -
> -       pv_time_ops = xen_time_ops;
> +       xen_init_time_ops();
>         x86_init.timers.setup_percpu_clockev = xen_time_init;
>         x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents;

Boris reported a bug on HVM, which causes a panic in
x86_late_time_init(). It is introduced here: xen_init_time_ops() sets:
x86_init.timers.timer_init = xen_time_init; which was hpet_time_init()
in HVM. However, we might not even need hpet here. Thus, adding
x86_init.timers.timer_init = x86_init_noop; to the end of
xen_hvm_init_time_ops() should be sufficient.

Thank you,
Pavel
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux