On Tue, Jun 26, 2018 at 09:37:01AM +0300, Georgi Guninski wrote: > On Tue, Jun 26, 2018 at 08:05:47AM +0200, Heiko Carstens wrote: > > This is actually already the third time that somebody reports a potential > > buffer overflow for this function. Could you please add a comment in the > > code to avoid future confusion? > > This also confuses static analyzers and they don't read comments. > In one of the functions (alive in kernel 3.20) adding check is possible. Adding an extra, but superfluous, check would be fine with me as well. Given that it is obviously non-trivial to tell that this code isn't broken. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
