Re: [PATCH net V2 1/1] net/smc: coordinate wait queues for nonblocking connect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 21, 2018 at 7:23 AM, Ursula Braun <ubraun@xxxxxxxxxxxxx> wrote:
> @@ -605,6 +606,13 @@ static int smc_connect(struct socket *sock, struct sockaddr *addr,
>
>         smc_copy_sock_settings_to_clc(smc);
>         tcp_sk(smc->clcsock->sk)->syn_smc = 1;
> +       if (flags & O_NONBLOCK) {
> +               rcu_read_lock();
> +               smc->smcwq = rcu_dereference(sk->sk_wq);
> +               rcu_assign_pointer(sock->sk->sk_wq,
> +                                  rcu_dereference(smc->clcsock->sk->sk_wq));
> +               rcu_read_unlock();

Are you really deref'ing any RCU pointer here?
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux