From: Ursula Braun <ubraun@xxxxxxxxxxxxx> Date: Tue, 17 Apr 2018 17:18:13 +0200 > From: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx> > > TCP sockopts must not interfere with the CLC handshake on the > CLC socket. Therefore, we defer some of them till the CLC > handshake has completed, like resetting TCP_NODELAY. > > While touching setsockopt, the TCP_FASTOPEN sockopts are > ignored, since SMC-connection setup is based on the TCP > three-way-handshake. > > Signed-off-by: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx> Especially with fast-open, if you don't support the socket option you should signal an error. Also, the deferral mechanism means you'll never properly propagate any errors back to the user. The kernel_setsockopt() return value isn't validated at all. Color me not impressed at all with this change. These kind of things have to have clear and proper semantics, plus full error processing with proper propagation back to the user. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
