[s390:for-linus 23/23] arch/s390/kernel/nospec-branch.c:90:9: warning: 'return' with a value, in function returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus
head:   a037c2e43b434cf845a4521d6b2865f27047c1db
commit: a037c2e43b434cf845a4521d6b2865f27047c1db [23/23] s390: correct nospec auto detection init order
config: s390-allmodconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout a037c2e43b434cf845a4521d6b2865f27047c1db
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All warnings (new ones prefixed by >>):

   arch/s390/kernel/nospec-branch.c: In function 'nospec_auto_detect':
>> arch/s390/kernel/nospec-branch.c:90:9: warning: 'return' with a value, in function returning void
     return 0;
            ^
   arch/s390/kernel/nospec-branch.c:75:13: note: declared here
    void __init nospec_auto_detect(void)
                ^~~~~~~~~~~~~~~~~~

vim +/return +90 arch/s390/kernel/nospec-branch.c

f19fbd5e Martin Schwidefsky 2018-01-26  74  
a037c2e4 Martin Schwidefsky 2018-04-11  75  void __init nospec_auto_detect(void)
f19fbd5e Martin Schwidefsky 2018-01-26  76  {
6e179d64 Martin Schwidefsky 2018-03-23  77  	if (IS_ENABLED(CC_USING_EXPOLINE)) {
6e179d64 Martin Schwidefsky 2018-03-23  78  		/*
6e179d64 Martin Schwidefsky 2018-03-23  79  		 * The kernel has been compiled with expolines.
6e179d64 Martin Schwidefsky 2018-03-23  80  		 * Keep expolines enabled and disable nobp.
6e179d64 Martin Schwidefsky 2018-03-23  81  		 */
6e179d64 Martin Schwidefsky 2018-03-23  82  		nospec_disable = 0;
6e179d64 Martin Schwidefsky 2018-03-23  83  		__clear_facility(82, S390_lowcore.alt_stfle_fac_list);
f19fbd5e Martin Schwidefsky 2018-01-26  84  	}
6e179d64 Martin Schwidefsky 2018-03-23  85  	/*
6e179d64 Martin Schwidefsky 2018-03-23  86  	 * If the kernel has not been compiled with expolines the
6e179d64 Martin Schwidefsky 2018-03-23  87  	 * nobp setting decides what is done, this depends on the
6e179d64 Martin Schwidefsky 2018-03-23  88  	 * CONFIG_KERNEL_NP option and the nobp/nospec parameters.
6e179d64 Martin Schwidefsky 2018-03-23  89  	 */
6e179d64 Martin Schwidefsky 2018-03-23 @90  	return 0;
f19fbd5e Martin Schwidefsky 2018-01-26  91  }
6e179d64 Martin Schwidefsky 2018-03-23  92  

:::::: The code at line 90 was first introduced by commit
:::::: 6e179d64126b909f0b288fa63cdbf07c531e9b1d s390: add automatic detection of the spectre defense

:::::: TO: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
:::::: CC: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux