Dave Young <dyoung@xxxxxxxxxx> writes: > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: >> As arch_kexec_kernel_image_{probe,load}(), >> arch_kimage_file_post_load_cleanup() and arch_kexec_kernel_verify_sig() >> are almost duplicated among architectures, they can be commonalized with >> an architecture-defined kexec_file_ops array. So let's factor them out. >> >> Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> >> Cc: Dave Young <dyoung@xxxxxxxxxx> >> Cc: Vivek Goyal <vgoyal@xxxxxxxxxx> >> Cc: Baoquan He <bhe@xxxxxxxxxx> >> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx> >> Cc: Thiago Jung Bauermann <bauerman@xxxxxxxxxxxxxxxxxx> >> --- >> arch/powerpc/include/asm/kexec.h | 2 +- >> arch/powerpc/kernel/kexec_elf_64.c | 2 +- >> arch/powerpc/kernel/machine_kexec_file_64.c | 39 ++----------------- >> arch/x86/include/asm/kexec-bzimage64.h | 2 +- >> arch/x86/kernel/kexec-bzimage64.c | 2 +- >> arch/x86/kernel/machine_kexec_64.c | 45 +--------------------- >> include/linux/kexec.h | 13 +++---- >> kernel/kexec_file.c | 60 +++++++++++++++++++++++++++-- >> 8 files changed, 71 insertions(+), 94 deletions(-) >> > > For this patch it also needs some review from powerpc people. FWIW: Reviewed-by: Thiago Jung Bauermann <bauerman@xxxxxxxxxxxxxxxxxx> Also, tested on a ppc64le KVM guest: Tested-by: Thiago Jung Bauermann <bauerman@xxxxxxxxxxxxxxxxxx> -- Thiago Jung Bauermann IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html