Closing of a listen socket wakes up kernel_accept() of smc_tcp_listen_worker(), and then has to wait till smc_tcp_listen_worker() gives up the internal clcsock. This wait is non-interruptible, and does not fit to the interruptible wakeup in smc_tcp_listen_worker(). Thus wakeup fails, and waiting for the closed internal clcsock never ends before the wait timeout is reached. This patch introduces the matching non-interruptible wakeup. Fixes: 127f49705823 ("net/smc: release clcsock from tcp_listen_worker") Reported-by: Hans Wippel <hwippel@xxxxxxxxxxxxxxxxxx> Signed-off-by: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx> --- net/smc/af_smc.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 8cc97834d4f6..ad4c43eb7e7f 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c @@ -946,6 +946,20 @@ static void smc_listen_work(struct work_struct *work) goto enqueue; /* queue new sock with sk_err set */ } +/* a non-interruptible variant of sock_def_wakeup() for wakeup of + * smc_close_wait_listen_clcsock() + */ +static void smc_sock_wakeup(struct sock *sk) +{ + struct socket_wq *wq; + + rcu_read_lock(); + wq = rcu_dereference(sk->sk_wq); + if (skwq_has_sleeper(wq)) + wake_up_all(&wq->wait); + rcu_read_unlock(); +} + static void smc_tcp_listen_work(struct work_struct *work) { struct smc_sock *lsmc = container_of(work, struct smc_sock, @@ -981,7 +995,7 @@ static void smc_tcp_listen_work(struct work_struct *work) /* no more listening, wake up smc_close_wait_listen_clcsock and * accept */ - lsk->sk_state_change(lsk); + smc_sock_wakeup(lsk); sock_put(&lsmc->sk); /* sock_hold in smc_listen */ } -- 2.13.5 -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html