Re: [PATCH 1/2] KVM: s390: fix fallthrough annotation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05.03.2018 12:16, Christian Borntraeger wrote:
> From: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
> 
> A case statement in kvm_s390_shadow_tables uses fallthrough annotations
> which are not recognized by gcc because they are hidden within a block.
> Move these annotations out of the block to fix (W=1) warnings like below:
> 
> arch/s390/kvm/gaccess.c: In function 'kvm_s390_shadow_tables':
> arch/s390/kvm/gaccess.c:1029:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   case ASCE_TYPE_REGION1: {
>                           ^
> 
> Signed-off-by: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> ---
>  arch/s390/kvm/gaccess.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/s390/kvm/gaccess.c b/arch/s390/kvm/gaccess.c
> index c24bfa72baf7..8e2b8647ee12 100644
> --- a/arch/s390/kvm/gaccess.c
> +++ b/arch/s390/kvm/gaccess.c
> @@ -1050,8 +1050,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
>  		rc = gmap_shadow_r2t(sg, saddr, rfte.val, *fake);
>  		if (rc)
>  			return rc;
> -		/* fallthrough */
> -	}
> +	} /* fallthrough */
>  	case ASCE_TYPE_REGION2: {
>  		union region2_table_entry rste;
>  
> @@ -1077,8 +1076,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
>  		rc = gmap_shadow_r3t(sg, saddr, rste.val, *fake);
>  		if (rc)
>  			return rc;
> -		/* fallthrough */
> -	}
> +	} /* fallthrough */
>  	case ASCE_TYPE_REGION3: {
>  		union region3_table_entry rtte;
>  
> @@ -1113,8 +1111,7 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
>  		rc = gmap_shadow_sgt(sg, saddr, rtte.val, *fake);
>  		if (rc)
>  			return rc;
> -		/* fallthrough */
> -	}
> +	} /* fallthrough */
>  	case ASCE_TYPE_SEGMENT: {
>  		union segment_table_entry ste;
>  
> 

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

-- 

Thanks,

David / dhildenb
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux