On 02/11/2018 11:27 PM, Ingo Molnar wrote: > > * Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> >> Currently <linux/slab.h> #includes <linux/kmemleak.h> for no obvious >> reason. It looks like it's only a convenience, so remove kmemleak.h >> from slab.h and add <linux/kmemleak.h> to any users of kmemleak_* >> that don't already #include it. >> Also remove <linux/kmemleak.h> from source files that do not use it. >> >> This is tested on i386 allmodconfig and x86_64 allmodconfig. It >> would be good to run it through the 0day bot for other $ARCHes. >> I have neither the horsepower nor the storage space for the other >> $ARCHes. >> >> [slab.h is the second most used header file after module.h; kernel.h >> is right there with slab.h. There could be some minor error in the >> counting due to some #includes having comments after them and I >> didn't combine all of those.] >> >> This is Lingchi patch #1 (death by a thousand cuts, applied to kernel >> header files). >> >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Nice find: > > Reviewed-by: Ingo Molnar <mingo@xxxxxxxxxx> > > I agree that it needs to go through 0-day to find any hidden dependencies we might > have grown due to this. Andrew, This patch has mostly survived both 0day and ozlabs multi-arch testing with 2 build errors being reported by both of them. I have posted patches for those separately. (and are attached here) other-patch-1: lkml.kernel.org/r/5664ced1-a0cd-7e4e-71b6-9c3a97d68927@xxxxxxxxxxxxx "lib/test_firmware: add header file to prevent build errors" other-patch-2: lkml.kernel.org/r/b3b7eebb-0e9f-f175-94a8-379c5ddcaa86@xxxxxxxxxxxxx "integrity/security: fix digsig.c build error" Will you see that these are merged or do you want me to repost them? thanks, -- ~Randy
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> security/integrity/digsig.c has build errors on some $ARCH due to a missing header file, so add it. security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Cc: Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> Cc: linux-integrity@xxxxxxxxxxxxxxx Link: http://kisskb.ellerman.id.au/kisskb/head/13396/ --- security/integrity/digsig.c | 1 + 1 file changed, 1 insertion(+) --- lnx-416-rc1.orig/security/integrity/digsig.c +++ lnx-416-rc1/security/integrity/digsig.c @@ -18,6 +18,7 @@ #include <linux/cred.h> #include <linux/key-type.h> #include <linux/digsig.h> +#include <linux/vmalloc.h> #include <crypto/public_key.h> #include <keys/system_keyring.h>
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> lib/test_firmware.c has build errors on some $ARCH due to a missing header file, so add it. lib/test_firmware.c:134:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] lib/test_firmware.c:620:25: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx> Cc: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Link: http://kisskb.ellerman.id.au/kisskb/head/13396/ --- lib/test_firmware.c | 1 + 1 file changed, 1 insertion(+) --- lnx-416-rc1.orig/lib/test_firmware.c +++ lnx-416-rc1/lib/test_firmware.c @@ -21,6 +21,7 @@ #include <linux/uaccess.h> #include <linux/delay.h> #include <linux/kthread.h> +#include <linux/vfree.h> #define TEST_FIRMWARE_NAME "test-firmware.bin" #define TEST_FIRMWARE_NUM_REQS 4
