On 02/13/2018 02:09 AM, Michael Ellerman wrote: > Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes: > >> On 02/12/2018 04:28 AM, Michael Ellerman wrote: >>> Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes: >>> >>>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >>>> >>>> Currently <linux/slab.h> #includes <linux/kmemleak.h> for no obvious >>>> reason. It looks like it's only a convenience, so remove kmemleak.h >>>> from slab.h and add <linux/kmemleak.h> to any users of kmemleak_* >>>> that don't already #include it. >>>> Also remove <linux/kmemleak.h> from source files that do not use it. >>>> >>>> This is tested on i386 allmodconfig and x86_64 allmodconfig. It >>>> would be good to run it through the 0day bot for other $ARCHes. >>>> I have neither the horsepower nor the storage space for the other >>>> $ARCHes. >>>> >>>> [slab.h is the second most used header file after module.h; kernel.h >>>> is right there with slab.h. There could be some minor error in the >>>> counting due to some #includes having comments after them and I >>>> didn't combine all of those.] >>>> >>>> This is Lingchi patch #1 (death by a thousand cuts, applied to kernel >>>> header files). >>>> >>>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >>> >>> I threw it at a random selection of configs and so far the only failures >>> I'm seeing are: >>> >>> lib/test_firmware.c:134:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] >>> lib/test_firmware.c:620:25: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] >>> lib/test_firmware.c:620:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] >>> security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] >> >> Both of those source files need to #include <linux/vmalloc.h>. > > Yep, I added those and rebuilt. I don't see any more failures that look > related to your patch. Great, thanks. I also sent patches for both of those. > http://kisskb.ellerman.id.au/kisskb/head/13399/ > > > I haven't gone through the defconfigs I have enabled for a while, so > it's possible I have some missing but it's still a reasonable cross > section. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
