Bjorn, On Tue, Jan 30, 2018 at 1:40 AM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > I previously posted patches [1] to add SPDX tags to all drivers/pci files > except drivers/pci/hotplug/s390_pci_hpc.c. I omitted that one because it > contained only a "License: GPL" comment, which I thought was ambiguous. > > However, I think it is actually unambiguous because the file was added with > a 'MODULE_LICENSE("GPL")', and include/linux/module.h shows that means "GPL > v2 or later". > > So this patch adds the GPL-2.0+ tag to the file. I plan to include this > for v4.16 unless somebody objects. As I as said in a previous email, context matters a lot in these case and you made the right choice. When there is a MODULE_LICENSE and a super terse "GPL" license notice, the two taken together can provide the proper context e.g. here GPL-2.0+ rather than a less common GPL-1.0+ Thank you for your efforts there! -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html