On 01/23/2018 01:31 AM, Joe Perches wrote: > On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote: >> >> On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: >>> Return statements in functions returning bool should use >>> true/false instead of 1/0. >>> >>> This issue was detected with the help of Coccinelle. >>> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> >>> --- >>> Changes in v2: >>> - Fix function using_ipsec as suggested by Ursula Braun. >>> - Update subject line. >>> >>> net/smc/smc.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/net/smc/smc.h b/net/smc/smc.h > [] >>> @@ -253,12 +253,12 @@ static inline int smc_uncompress_bufsize(u8 compressed) >>> static inline bool using_ipsec(struct smc_sock *smc) >>> { >>> return (smc->clcsock->sk->sk_policy[0] || >>> - smc->clcsock->sk->sk_policy[1]) ? 1 : 0; >>> + smc->clcsock->sk->sk_policy[1]) ? true : false; > > Generally, any bool return like > > return condition ? true : false; > > could be written > > return condition; > This would be shorter, but is it really better readable/understandable? Do you have a reference for us confirming your proposed style is the way to go? -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html