On Fri, 8 Dec 2017 13:21:47 +0900 Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx> wrote: > I'll also escalate it to s390 people > > Martin, Heiko, > > we discovered a sort of build order dependency while working on a > printk related patch set. we now have extra inclused in kallsyms.h, > namely, > > #include <linux/mm.h> > #include <linux/module.h> > #include <asm/sections.h> > > > and this gives us the following build warning: > > On (12/08/17 11:05), Sergey Senozhatsky wrote: > > > > On (12/08/17 02:07), kbuild test robot wrote: > > > All warnings (new ones prefixed by >>): > > > > > > In file included from arch/s390/include/asm/elf.h:141:0, > > > from include/linux/elf.h:5, > > > from include/linux/module.h:15, > > > from include/linux/kallsyms.h:13, > > > from kernel//sched/autogroup.c:6: > > > >> arch/s390/include/asm/mmu_context.h:111:0: warning: "finish_arch_post_lock_switch" redefined > > > #define finish_arch_post_lock_switch finish_arch_post_lock_switch > > > > > > In file included from kernel//sched/autogroup.c:2:0: > > > kernel//sched/sched.h:1328:0: note: this is the location of the previous definition > > > # define finish_arch_post_lock_switch() do { } while (0) > > > any chance you can help us out? Move the include of "sched.h" in autogroup.c after all the other includes. For the #ifndef in sched.h to work the arch specific definition in mmu_context.h needs to be seen first. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html